[Linuxwacom-devel] [PATCH libwacom] data: enable modes on the ExpressKey Remote

[Benjamin Tissoires]

While it's true modes are read-only and it doesn't change a bit on X.org,
under wayland, we need to have the number of modes and the toggle key.

The first change in X.org is that now g-s-d calls gsd-wacom-led-helper
to try to set the LED, but this just fails and no one cares actually.

The second change is that now the OSD shows modes and might be out of
sync with the actual mode in use. It's not a big issue as right now
g-c-c doesn't show anything for the EKR so users who are actually using
the OSD played with dconf and are not beginners. Given that g-c-c needs
fixes for the EKR, we can also make sure g-s-d updates the mode according
to what the hardware provides.

Signed-off-by: Benjamin Tissoires <***@redhat.com>
---
data/ek-remote.tablet | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/ek-remote.tablet b/data/ek-remote.tablet
index bc9ff73..4bbe8fb 100644
--- a/data/ek-remote.tablet
+++ b/data/ek-remote.tablet
@@ -22,7 +22,7 @@ Stylus=false
Ring=true
NumStrips=0
Buttons=18
-#StatusLEDs=Ring
+StatusLEDs=Ring

[Buttons]
Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
@@ -30,5 +30,5 @@ Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
#Note that though this device has 3 ring modes
#this mode selection does not function the same
#as previous devices. The EKR's mode is read-only.
-#RingNumModes=3
+RingNumModes=3
Ring=A

[Ping Cheng]

On Wed, Jul 13, 2016 at 11:05 AM, Benjamin Tissoires

Post by Benjamin Tissoires
While it's true modes are read-only and it doesn't change a bit on X.org,
under wayland, we need to have the number of modes and the toggle key.
The first change in X.org is that now g-s-d calls gsd-wacom-led-helper
to try to set the LED, but this just fails and no one cares actually.
The second change is that now the OSD shows modes and might be out of
sync with the actual mode in use. It's not a big issue as right now
g-c-c doesn't show anything for the EKR so users who are actually using
the OSD played with dconf and are not beginners. Given that g-c-c needs
fixes for the EKR, we can also make sure g-s-d updates the mode according
to what the hardware provides.

It makes sense to me. I bet Aaron knew we would need those info sooner
or later ;).
Acked-by: Ping Cheng <***@wacom.com>

Cheers,

Ping

Post by Benjamin Tissoires
---
data/ek-remote.tablet | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/ek-remote.tablet b/data/ek-remote.tablet
index bc9ff73..4bbe8fb 100644
--- a/data/ek-remote.tablet
+++ b/data/ek-remote.tablet
@@ -22,7 +22,7 @@ Stylus=false
Ring=true
NumStrips=0
Buttons=18
-#StatusLEDs=Ring
+StatusLEDs=Ring
[Buttons]
Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
@@ -30,5 +30,5 @@ Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
#Note that though this device has 3 ring modes
#this mode selection does not function the same
#as previous devices. The EKR's mode is read-only.
-#RingNumModes=3
+RingNumModes=3
Ring=A
--
2.5.5
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Linuxwacom-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

[Peter Hutterer]

Post by Ping Cheng
On Wed, Jul 13, 2016 at 11:05 AM, Benjamin Tissoires

Post by Benjamin Tissoires
While it's true modes are read-only and it doesn't change a bit on X.org,
under wayland, we need to have the number of modes and the toggle key.
The first change in X.org is that now g-s-d calls gsd-wacom-led-helper
to try to set the LED, but this just fails and no one cares actually.
The second change is that now the OSD shows modes and might be out of
sync with the actual mode in use. It's not a big issue as right now
g-c-c doesn't show anything for the EKR so users who are actually using
the OSD played with dconf and are not beginners. Given that g-c-c needs
fixes for the EKR, we can also make sure g-s-d updates the mode according
to what the hardware provides.

It makes sense to me. I bet Aaron knew we would need those info sooner
or later ;).

merged, thanks.

Cheers,
Peter

Post by Ping Cheng

Post by Benjamin Tissoires
---
data/ek-remote.tablet | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/ek-remote.tablet b/data/ek-remote.tablet
index bc9ff73..4bbe8fb 100644
--- a/data/ek-remote.tablet
+++ b/data/ek-remote.tablet
@@ -22,7 +22,7 @@ Stylus=false
Ring=true
NumStrips=0
Buttons=18
-#StatusLEDs=Ring
+StatusLEDs=Ring
[Buttons]
Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
@@ -30,5 +30,5 @@ Left=A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R
#Note that though this device has 3 ring modes
#this mode selection does not function the same
#as previous devices. The EKR's mode is read-only.
-#RingNumModes=3
+RingNumModes=3
Ring=A
--
2.5.5
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Linuxwacom-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Linuxwacom-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel